fix: update release notes generation rules for clarity and formatting#351
Merged
frontegg-david merged 1 commit intomainfrom Apr 9, 2026
Merged
fix: update release notes generation rules for clarity and formatting#351frontegg-david merged 1 commit intomainfrom
frontegg-david merged 1 commit intomainfrom
Conversation
Contributor
📝 WalkthroughWalkthroughThe pull request updates a GitHub Actions release workflow by modifying the OpenAI system prompt to emphasize a "benefit-focused tone" and adjusting CARD_MDX formatting requirements to include en dashes and blank-line separation. A post-processing Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/publish-release.yml (1)
471-479: Make CARD_MDX bullet detection structure-based, not emoji allow-list based.Line [473] hard-codes emoji values. If the model outputs a valid but unlisted emoji, spacing normalization won’t run for that bullet.
Proposed diff
- awk ' - /^[[:space:]]*(🔌|🔄|📋|⚡|💾|🔐|🎨|☁️|🌐|📦|🔧|🪝|🔑|🚀|🛡️|✨|🔍|🧩|🔒|🔥|🎯|⚙️|📝)/ { + awk ' + /^[[:space:]]*[^[:space:]]+[[:space:]]+\*\*[^*]+\*\*[[:space:]]+[-–—][[:space:]]+/ { if (prev_was_bullet) print "" prev_was_bullet = 1 print; next } { prev_was_bullet = 0; print } ' /tmp/card-mdx.txt > /tmp/card-mdx-fixed.txt && mv /tmp/card-mdx-fixed.txt /tmp/card-mdx.txt🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/publish-release.yml around lines 471 - 479, The current awk block uses a hard-coded emoji allow-list to detect bullet lines (the regex in the awk script and prev_was_bullet logic operating on /tmp/card-mdx.txt), so unlisted emojis won’t get double-newline normalization; change the detection to a structure-based regex that matches any leading emoji/unicode pictograph (e.g., use a Unicode property like \p{Extended_Pictographic} or a broad emoji character class) instead of the explicit list, keep the prev_was_bullet flag and the same print/empty-line insertion logic, and write the transformed output to /tmp/card-mdx-fixed.txt as before then mv back to /tmp/card-mdx.txt.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/publish-release.yml:
- Around line 471-479: The current awk block uses a hard-coded emoji allow-list
to detect bullet lines (the regex in the awk script and prev_was_bullet logic
operating on /tmp/card-mdx.txt), so unlisted emojis won’t get double-newline
normalization; change the detection to a structure-based regex that matches any
leading emoji/unicode pictograph (e.g., use a Unicode property like
\p{Extended_Pictographic} or a broad emoji character class) instead of the
explicit list, keep the prev_was_bullet flag and the same print/empty-line
insertion logic, and write the transformed output to /tmp/card-mdx-fixed.txt as
before then mv back to /tmp/card-mdx.txt.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5fffbee1-f3fe-436e-995a-e095da2a8b0c
📒 Files selected for processing (1)
.github/workflows/publish-release.yml
Contributor
Performance Test ResultsStatus: ✅ All tests passed Summary
Total: 101 tests across 21 projects 📊 View full report in workflow run Generated at: 2026-04-09T05:12:36.602Z |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit